Issue 10918015: Make HWNDMessageHandler build with use_aura==1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918015: Make HWNDMessageHandler build with use_aura==1 (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make HWNDMessageHandler build with use_aura==1 http://crbug.com/142962 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154497

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -65 lines)			Patch
M	ui/ui.gyp	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2	1 chunk	+0 lines, -11 lines	0 comments	Download
M	ui/views/widget/native_widget_win.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View	1 2	4 chunks	+45 lines, -2 lines	0 comments	Download
M	ui/views/win/DEPS	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/win/hwnd_message_handler.h	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	1 2	17 chunks	+38 lines, -44 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler_delegate.h	View	1 2	1 chunk	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Another real one. I had to shuffle InputMethod handling back over to NWW. It's too ...

8 years, 3 months ago (2012-08-30 23:26:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10918015/4001

8 years, 3 months ago (2012-08-31 00:58:52 UTC) #3

commit-bot: I haz the power

8 years, 3 months ago (2012-08-31 02:16:37 UTC) #4

Try job failure for 10918015-4001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages