Restrict objects printing in disassembler to avoid GC.

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 372 matching lines @@
 }
 
 
 void X86Decoder::PrintXmmRegister(int reg) {
   ASSERT(0 <= reg);
   ASSERT(reg < kMaxXmmRegisters);
   Print(xmm_regs[reg]);
 }
 
 
+static const char* ObjectToCStringNoGC(const Object& obj) {
+  if (obj.IsSmi() ||
+      obj.IsMint() ||
+      obj.IsDouble() ||
+      obj.IsString() ||
+      obj.IsNull() ||
+      obj.IsBool() ||
+      obj.IsClass() ||
+      obj.IsFunction() ||
+      obj.IsICData() ||
+      obj.IsField()) {
+    return obj.ToCString();
+  }
+
+  const Class& clazz = Class::CheckedHandle(obj.clazz());
+  const char* full_class_name = clazz.ToCString();
+  const char* format = "instance of %s";
+  intptr_t len = OS::SNPrint(NULL, 0, format, full_class_name) + 1;
+  char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
+  OS::SNPrint(chars, len, format, full_class_name);
+  return chars;
+}
+
+
 void X86Decoder::PrintAddress(uword addr) {
   NoGCScope no_gc;
   char addr_buffer[32];
   OS::SNPrint(addr_buffer, sizeof(addr_buffer), "%p", addr);
   Print(addr_buffer);
   // Try to print as heap object or stub name
   if (!Isolate::Current()->heap()->CodeContains(addr) &&
       Isolate::Current()->heap()->Contains(addr - kHeapObjectTag)) {
     Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
     if (obj.IsArray()) {
       const Array& arr = Array::CheckedHandle(obj.raw());
       intptr_t len = arr.Length();
       if (len > 5) len = 5;  // Print a max of 5 elements.
       Print("  Array[");
       int i = 0;
       while (i < len) {
         obj = arr.At(i);
         if (i > 0) Print(", ");
-        Print(obj.ToCString());
+        Print(ObjectToCStringNoGC(obj));
         i++;
       }
       if (i < arr.Length()) Print(", ...");
       Print("]");
       return;
     }
     Print("  '");
-    Print(obj.ToCString());
+    Print(ObjectToCStringNoGC(obj));
     Print("'");
   } else {
     // 'addr' is not an object, but probably a code address.
     const char* name_of_stub = StubCode::NameOfStub(addr);
     if (name_of_stub != NULL) {
       Print("  [stub: ");
       Print(name_of_stub);
       Print("]");
     } else {
       // Print only if jumping to entry point.
@@ skipping 1175 matching lines @@
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32