Issue 10918005: Elements load depends on the type of the receiver.

Issue 10918005: Elements load depends on the type of the receiver. (Closed)

Created:
8 years, 3 months ago by Toon Verwaest

Modified:
8 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Elements load depends on the type of the receiver. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12413

Patch Set 2 : Addressed comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -29 lines)			Patch
M	src/hydrogen.cc	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+6 lines, -2 lines	0 comments	Download
A +	test/mjsunit/regress/regress-load-elements.js	View	1	1 chunk	+15 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc#newcode6191 src/hydrogen.cc:6191: HInstruction* elements = AddInstruction(new(zone()) HLoadElements(object, nit: ...

8 years, 3 months ago (2012-08-30 16:42:03 UTC) #2

Toon Verwaest

8 years, 3 months ago (2012-08-30 17:27:08 UTC) #3

Addressed comments.

https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:6191: HInstruction* elements = AddInstruction(new(zone())
HLoadElements(object,
On 2012/08/30 16:42:03, Jakob wrote:
> nit: let's be consistent and break the line after '='.

Done.

https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:6379: HInstruction* elements = AddInstruction(new(zone())
HLoadElements(object,
On 2012/08/30 16:42:03, Jakob wrote:
> nit: let's be consistent and break the line after '='.

Done.

https://chromiumcodereview.appspot.com/10918005/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-load-elements.js (right):

https://chromiumcodereview.appspot.com/10918005/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-load-elements.js:45: // Optimize, before the fix,
the element load and subsequent tagged-to-i were
On 2012/08/30 16:42:03, Jakob wrote:
> Outdated comment. At least, s/tagged-to-i/fixed-array-length/

Done.

Expand Messages | Collapse Messages