net/base/multi_threaded_cert_verifier_unittest.cc - Issue 10917309: Make MultiThreadedCertVerifier receive a CertVerifyProc, rather than creating one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/multi_threaded_cert_verifier_unittest.cc

Issue 10917309: Make MultiThreadedCertVerifier receive a CertVerifyProc, rather than creating one (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/multi_threaded_cert_verifier_unittest.cc

diff --git a/net/base/multi_threaded_cert_verifier_unittest.cc b/net/base/multi_threaded_cert_verifier_unittest.cc

index 7bf47a21563b2b96ff4b8100395f182ac935b603..8946b660845b8a50a9ea2ce400cb2609f41fdff0 100644

--- a/net/base/multi_threaded_cert_verifier_unittest.cc

+++ b/net/base/multi_threaded_cert_verifier_unittest.cc

@@ -49,9 +49,7 @@ class MockCertVerifyProc : public CertVerifyProc {

class MultiThreadedCertVerifierTest : public ::testing::Test {

public:

- MultiThreadedCertVerifierTest() {

- verifier_.SetCertVerifyProc(new MockCertVerifyProc());

- }

+ MultiThreadedCertVerifierTest() : verifier_(new MockCertVerifyProc()) {}

wtc 2012/09/18 02:51:55 This is good. The original code required us to cre

virtual ~MultiThreadedCertVerifierTest() {}

protected:

« no previous file with comments | « net/base/multi_threaded_cert_verifier.cc ('k') | no next file » | no next file with comments »