Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2434)

Issue 10917309: Make MultiThreadedCertVerifier receive a CertVerifyProc, rather than creating one (Closed)

Created:
8 years, 3 months ago by Ryan Sleevi
Modified:
8 years, 3 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Make MultiThreadedCertVerifier receive a CertVerifyProc, rather than creating one Rather than creating an OS-specific CertVerifyProc, have it injected into the MultiThreadedCertVerifier directly. This allows callers to change the CertVerifyProc that is used. BUG=123666 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157504

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M net/base/cert_verifier.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/multi_threaded_cert_verifier.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/base/multi_threaded_cert_verifier.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/base/multi_threaded_cert_verifier_unittest.cc View 1 chunk +1 line, -3 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
wtc: Easy review Context/purpose: Being able to create one MultiThreadedCertVerifier for libpkix, another for CDSA.
8 years, 3 months ago (2012-09-18 00:18:45 UTC) #1
wtc
Patch set 1 LGTM! http://codereview.chromium.org/10917309/diff/1/net/base/multi_threaded_cert_verifier_unittest.cc File net/base/multi_threaded_cert_verifier_unittest.cc (right): http://codereview.chromium.org/10917309/diff/1/net/base/multi_threaded_cert_verifier_unittest.cc#newcode52 net/base/multi_threaded_cert_verifier_unittest.cc:52: MultiThreadedCertVerifierTest() : verifier_(new MockCertVerifyProc()) {} ...
8 years, 3 months ago (2012-09-18 02:51:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10917309/1
8 years, 3 months ago (2012-09-19 01:35:46 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 04:17:04 UTC) #4
Change committed as 157504

Powered by Google App Engine
This is Rietveld 408576698