Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 10917306: Allow the caller to specify a username and password so that private issues (Closed)

Created:
8 years, 3 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Allow the caller to specify a username and password so that private issues can be applied. This is the first part for this bug; the second part is in commands.py where this is called by the TS. BUG=149941 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157355

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M apply_issue.py View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roger Tawa OOO till Jul 10th
8 years, 3 months ago (2012-09-17 22:47:34 UTC) #1
M-A Ruel
http://codereview.chromium.org/10917306/diff/1/apply_issue.py File apply_issue.py (right): http://codereview.chromium.org/10917306/diff/1/apply_issue.py#newcode69 apply_issue.py:69: print('Accessing the issue requires login.') I'd prefer to keep ...
8 years, 3 months ago (2012-09-17 23:13:27 UTC) #2
Roger Tawa OOO till Jul 10th
Merci MA. Comments addressed, changes uploaded. Please take another look. http://codereview.chromium.org/10917306/diff/1/apply_issue.py File apply_issue.py (right): http://codereview.chromium.org/10917306/diff/1/apply_issue.py#newcode69 ...
8 years, 3 months ago (2012-09-18 14:31:35 UTC) #3
M-A Ruel
lgtm
8 years, 3 months ago (2012-09-18 14:38:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10917306/4001
8 years, 3 months ago (2012-09-18 14:46:50 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 14:49:44 UTC) #6
Change committed as 157355

Powered by Google App Engine
This is Rietveld 408576698