Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10917269: Use a single flag for enabling experimental WebKit features. (Closed)

Created:
8 years, 3 months ago by tony
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, laforge
Visibility:
Public.

Description

Use a single flag for enabling experimental WebKit features. Merge multiple command line webkit features into a single flag. This has the benefit that when a new feature is added, we can add it to this flag rather than requiring users to toggle another flag. This is similar to what extensions does for experimental APIs. BUG=148503 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157014

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -75 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +4 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/public/common/content_switches.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tony
This includes exclusions, regions, style scoped, shadow DOM and variables. Should I add anything else? ...
8 years, 3 months ago (2012-09-14 18:20:36 UTC) #1
ojan
LGTM (I'm not an owner though). I think this is great for now. There's a ...
8 years, 3 months ago (2012-09-14 18:39:14 UTC) #2
darin (slow to review)
LGTM
8 years, 3 months ago (2012-09-14 20:25:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10917269/1
8 years, 3 months ago (2012-09-14 20:28:13 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) build
8 years, 3 months ago (2012-09-14 20:42:50 UTC) #5
dglazkov
Will we need to add the "Disable Shadow DOM" flag back when we turn the ...
8 years, 3 months ago (2012-09-14 21:11:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10917269/1
8 years, 3 months ago (2012-09-14 21:11:46 UTC) #7
tony
On 2012/09/14 21:11:34, Dimitri Glazkov wrote: > Will we need to add the "Disable Shadow ...
8 years, 3 months ago (2012-09-14 21:13:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10917269/1
8 years, 3 months ago (2012-09-14 21:14:12 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) build
8 years, 3 months ago (2012-09-14 21:29:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10917269/13002
8 years, 3 months ago (2012-09-14 21:31:36 UTC) #11
commit-bot: I haz the power
Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...
8 years, 3 months ago (2012-09-15 17:39:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10917269/13002
8 years, 3 months ago (2012-09-15 17:40:44 UTC) #13
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 20:20:08 UTC) #14
Change committed as 157014

Powered by Google App Engine
This is Rietveld 408576698