Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 10917266: Rename "chrome/browser/policy/policy_constants.h" so that it doesn't clash with the generated "poli… (Closed)

Created:
8 years, 3 months ago by Joao da Silva
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Mattias Nissler (ping if slow), ramant (doing other things)
Visibility:
Public.

Description

Rename "chrome/browser/policy/policy_constants.h" so that it doesn't clash with the generated "policy/policy_constants.h" when it is included from chrome/browser. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -43 lines) Patch
M chrome/browser/policy/cloud_policy_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_test.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/policy_constants.h View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/policy/policy_map.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/policy/policy_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
@thakis: can you stamp this please :-) Thanks! @mnissler, @rtenneti: FYI
8 years, 3 months ago (2012-09-14 17:47:29 UTC) #1
Mattias Nissler (ping if slow)
lgtm
8 years, 3 months ago (2012-09-14 18:16:46 UTC) #2
Nico
lgtm
8 years, 3 months ago (2012-09-15 13:13:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10917266/1
8 years, 3 months ago (2012-09-15 13:13:19 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-15 15:32:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10917266/1
8 years, 3 months ago (2012-09-15 20:00:27 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 20:37:26 UTC) #7
Change committed as 157016

Powered by Google App Engine
This is Rietveld 408576698