Disable the seccomp-bpf sandbox on ARM temporarily.

Disable the seccomp-bpf sandbox on ARM temporarily.


BUG=148856
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156904

[jln (very slow on Chromium), 2012-09-14 00:58:57]

We don't have time to fix the ARM syscall iteration bug immediately, so
temporarily disable the sandbox in the meantime.

(We don't loose much, the sandbox was only restricting ptrace on ARM).

[Markus (顧孟勤), 2012-09-14 02:46:00]

LGTM

On Thursday, September 13, 2012,  <jln@chromium.org> wrote:
> Reviewers: Jorge Lucangeli Obes, Markus (顧孟勤),
>
> Message:
> We don't have time to fix the ARM syscall iteration bug immediately, so
> temporarily disable the sandbox in the meantime.
>
> (We don't loose much, the sandbox was only restricting ptrace on ARM).
>
> Description:
> Disable the seccomp-bpf sandbox on ARM temporarily.
>
>
> BUG=148856
>
>
> Please review this at https://chromiumcodereview.appspot.com/10917249/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M content/common/sandbox_seccomp_bpf_linux.cc
>
>
> Index: content/common/sandbox_seccomp_bpf_linux.cc
> diff --git a/content/common/sandbox_seccomp_bpf_linux.cc
b/content/common/sandbox_seccomp_bpf_linux.cc
> index
f7f1a80ad6145c02b2073ce78e34bd7bf68445a6..a2e7569719ae544c0b6e4fcb7e0a25edf53e4a2a
100644
> --- a/content/common/sandbox_seccomp_bpf_linux.cc
> +++ b/content/common/sandbox_seccomp_bpf_linux.cc
> @@ -1409,12 +1409,17 @@ bool SandboxSeccompBpf::IsSeccompBpfDesired() {
>  bool SandboxSeccompBpf::ShouldEnableSeccompBpf(
>      const std::string& process_type) {
>  #if defined(SECCOMP_BPF_SANDBOX)
> +#if defined(__arm__)
> +  // We disable the sandbox on ARM for now until crbug.com/148856 is
fixed.
> +  return false;
> +#else
>    const CommandLine& command_line = *CommandLine::ForCurrentProcess();
>    if (process_type == switches::kGpuProcess)
>      return !command_line.HasSwitch(switches::kDisableGpuSandbox);
>
>    return true;
> -#endif
> +#endif  // __arm__
> +#endif  // process_type
>    return false;
>  }
>
>
>
>

[Jorge Lucangeli Obes, 2012-09-14 21:57:03]

I give up, I'm not going to be able to fix this before leaving.

lgtm

[commit-bot: I haz the power, 2012-09-14 21:59:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10917249/1

[commit-bot: I haz the power, 2012-09-14 22:20:35]

Change committed as 156904