src/api.cc - Issue 10917236: Not mask exception thrown by toString in String::UtfValue etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 10917236: Not mask exception thrown by toString in String::UtfValue etc. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index e8ab5a7bce22ad1ee7906dc14a7f9fe510327904..88d9a7d3413e83c360d65b188a2293cb23863c5a 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -5500,7 +5500,6 @@ String::Utf8Value::Utf8Value(v8::Handle<v8::Value> obj)

if (obj.IsEmpty()) return;

ENTER_V8(isolate);

i::HandleScope scope(isolate);

- TryCatch try_catch;

Handle<String> str = obj->ToString();

if (str.IsEmpty()) return;

i::Handle<i::String> i_str = Utils::OpenHandle(*str);

@@ -5522,7 +5521,6 @@ String::AsciiValue::AsciiValue(v8::Handle<v8::Value> obj)

if (obj.IsEmpty()) return;

ENTER_V8(isolate);

i::HandleScope scope(isolate);

- TryCatch try_catch;

Handle<String> str = obj->ToString();

if (str.IsEmpty()) return;

length_ = str->Length();

@@ -5543,7 +5541,6 @@ String::Value::Value(v8::Handle<v8::Value> obj)

if (obj.IsEmpty()) return;

ENTER_V8(isolate);

i::HandleScope scope(isolate);

- TryCatch try_catch;

Handle<String> str = obj->ToString();

if (str.IsEmpty()) return;

length_ = str->Length();

« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »