Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2928)

Unified Diff: chrome/browser/sessions/session_service_test_helper.cc

Issue 10917231: Revamp TabNavigation class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Mac Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_service.cc ('k') | chrome/browser/sessions/session_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_service_test_helper.cc
diff --git a/chrome/browser/sessions/session_service_test_helper.cc b/chrome/browser/sessions/session_service_test_helper.cc
index 3f02a4cfa352dd66ba093f38ee7e21ff7cba4081..62aac7c5cde8c34dbc2fcbece5a8db24668838dc 100644
--- a/chrome/browser/sessions/session_service_test_helper.cc
+++ b/chrome/browser/sessions/session_service_test_helper.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/sessions/session_id.h"
#include "chrome/browser/sessions/session_service.h"
#include "chrome/browser/sessions/session_types.h"
+#include "chrome/browser/sessions/session_types_test_helper.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::Time;
@@ -89,16 +90,7 @@ void SessionServiceTestHelper::AssertTabEquals(
void SessionServiceTestHelper::AssertNavigationEquals(
const TabNavigation& expected,
const TabNavigation& actual) {
- EXPECT_TRUE(expected.virtual_url() == actual.virtual_url());
- EXPECT_EQ(expected.referrer().url, actual.referrer().url);
- EXPECT_EQ(expected.referrer().policy, actual.referrer().policy);
- EXPECT_EQ(expected.title(), actual.title());
- EXPECT_EQ(expected.state(), actual.state());
- EXPECT_EQ(expected.transition(), actual.transition());
- EXPECT_EQ(expected.type_mask(), actual.type_mask());
- EXPECT_TRUE(expected.original_request_url() == actual.original_request_url());
- EXPECT_EQ(expected.is_overriding_user_agent(),
- actual.is_overriding_user_agent());
+ SessionTypesTestHelper::ExpectNavigationEquals(expected, actual);
}
void SessionServiceTestHelper::AssertSingleWindowWithSingleTab(
« no previous file with comments | « chrome/browser/sessions/session_service.cc ('k') | chrome/browser/sessions/session_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698