Revamp TabNavigation class

chrome/browser/ui/browser_tabrestore.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_tabrestore.h"
 
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/sessions/session_service.h"
 #include "chrome/browser/sessions/session_service_factory.h"
 #include "chrome/browser/tab_contents/tab_util.h"
@@ skipping 41 matching lines @@
   session_storage_namespace_map[""] = session_storage_namespace;
   TabContents* tab_contents = chrome::TabContentsWithSessionStorageFactory(
       browser->profile(),
       tab_util::GetSiteInstanceForNewTab(browser->profile(), restore_url),
       MSG_ROUTING_NONE,
       chrome::GetActiveWebContents(browser),
       session_storage_namespace_map);
   WebContents* new_tab = tab_contents->web_contents();
   extensions::TabHelper::FromWebContents(new_tab)->
       SetExtensionAppById(extension_app_id);
-  std::vector<NavigationEntry*> entries;
-  TabNavigation::CreateNavigationEntriesFromTabNavigations(
-      browser->profile(), navigations, &entries);
+  std::vector<NavigationEntry*> entries =
+      TabNavigation::CreateNavigationEntriesFromTabNavigations(
+          navigations, browser->profile());
   new_tab->SetUserAgentOverride(user_agent_override);
   new_tab->GetController().Restore(
       selected_navigation, from_last_session, &entries);
   DCHECK_EQ(0u, entries.size());
 
   int add_types = select ? TabStripModel::ADD_ACTIVE :
       TabStripModel::ADD_NONE;
   if (pin) {
     int first_mini_tab_idx =
         browser->tab_strip_model()->IndexOfFirstNonMiniTab();
@@ skipping 41 matching lines @@
   TabContents* tab_contents = chrome::TabContentsWithSessionStorageFactory(
       browser->profile(),
       tab_util::GetSiteInstanceForNewTab(browser->profile(), restore_url),
       MSG_ROUTING_NONE,
       GetActiveWebContents(browser),
       session_storage_namespace_map);
   WebContents* replacement = tab_contents->web_contents();
   extensions::TabHelper::FromWebContents(replacement)->
       SetExtensionAppById(extension_app_id);
   replacement->SetUserAgentOverride(user_agent_override);
-  std::vector<NavigationEntry*> entries;
-  TabNavigation::CreateNavigationEntriesFromTabNavigations(
-      browser->profile(), navigations, &entries);
+  std::vector<NavigationEntry*> entries =
+      TabNavigation::CreateNavigationEntriesFromTabNavigations(
+          navigations, browser->profile());
   replacement->GetController().Restore(
       selected_navigation, from_last_session, &entries);
   DCHECK_EQ(0u, entries.size());
 
   browser->tab_strip_model()->ReplaceNavigationControllerAt(
       browser->active_index(),
       tab_contents);
 }
 
 }  // namespace chrome