Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 10917214: Makes FramePainter not animate the header if the parent (a workspace) (Closed)

Created:
8 years, 3 months ago by sky
Modified:
8 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Makes FramePainter not animate the header if the parent (a workspace) is already animating. Doing so leads to lots of painting when switching workspaces and a bad frame rate for the animation. The rationale for disabling here is that if you are switching worskpaces, you're not going to notice the header animating. BUG=147350 TEST=none R=jamescook@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156339

Patch Set 1 #

Total comments: 2

Patch Set 2 : Spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M ash/wm/frame_painter.cc View 1 1 chunk +20 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
8 years, 3 months ago (2012-09-12 14:29:27 UTC) #1
James Cook
LGTM http://codereview.chromium.org/10917214/diff/1/ash/wm/frame_painter.cc File ash/wm/frame_painter.cc (right): http://codereview.chromium.org/10917214/diff/1/ash/wm/frame_painter.cc#newcode303 ash/wm/frame_painter.cc:303: // Don't animate the header if the parent ...
8 years, 3 months ago (2012-09-12 15:49:35 UTC) #2
sky
http://codereview.chromium.org/10917214/diff/1/ash/wm/frame_painter.cc File ash/wm/frame_painter.cc (right): http://codereview.chromium.org/10917214/diff/1/ash/wm/frame_painter.cc#newcode303 ash/wm/frame_painter.cc:303: // Don't animate the header if the parent (a ...
8 years, 3 months ago (2012-09-12 16:14:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10917214/3
8 years, 3 months ago (2012-09-12 16:14:36 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 18:44:04 UTC) #5
Change committed as 156339

Powered by Google App Engine
This is Rietveld 408576698