Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 10917211: Introduce new API to expose external string resource regardless of encoding. (Closed)

Created:
8 years, 3 months ago by Yang
Modified:
8 years, 3 months ago
Reviewers:
drcarney
CC:
v8-dev
Visibility:
Public.

Description

Introduce new API to expose external string resource regardless of encoding. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12488

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -3 lines) Patch
M include/v8.h View 1 5 chunks +37 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +10 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
This is a follow-up to http://codereview.chromium.org/10918169/ I changed the encoding to use an enum instead ...
8 years, 3 months ago (2012-09-12 10:23:55 UTC) #1
drcarney
lgtm http://codereview.chromium.org/10917211/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/10917211/diff/1/include/v8.h#newcode1243 include/v8.h:1243: * ASCII content is necessary. Looks like this ...
8 years, 3 months ago (2012-09-12 11:27:09 UTC) #2
Yang
8 years, 3 months ago (2012-09-12 11:28:50 UTC) #3
Addressed comments. Landing...

http://codereview.chromium.org/10917211/diff/1/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/10917211/diff/1/include/v8.h#newcode1243
include/v8.h:1243: * ASCII content is necessary.
On 2012/09/12 11:27:09, dcarney wrote:
> Looks like this comment accidentally slipped in.

Done.

Powered by Google App Engine
This is Rietveld 408576698