Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10917196: Fix memory leak in BookmarkUtilsTest.CopyPaste. (Closed)

Created:
8 years, 3 months ago by Elliot Glaysher
Modified:
8 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Fix memory leak in BookmarkUtilsTest.CopyPaste. BUG=130805 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156089

Patch Set 1 #

Patch Set 2 : Now with three other cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Sent to the linux_valgrind bot. Should I wait for results or just commit since I'm ...
8 years, 3 months ago (2012-09-11 18:16:43 UTC) #1
Lei Zhang
8 years, 3 months ago (2012-09-11 18:49:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698