Issue 10917188: Make Chrome OS Audio Player survive page reload and OS restart.

Issue 10917188: Make Chrome OS Audio Player survive page reload and OS restart. (Closed)

Created:
8 years, 3 months ago by Vladislav Kaznacheev

Modified:
8 years, 3 months ago

Reviewers:
Dmitry Polukhin, SeRya

CC:
chromium-reviews, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make Chrome OS Audio Player survive page reload and OS restart. BUG=chrome-os-partner:12208, chrome-os-partner:12947 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156278

Patch Set 1 #

Patch Set 2 : Removed debug trace #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+210 lines, -108 lines)			Patch
M	chrome/browser/chromeos/media/media_player.h	View		4 chunks	+4 lines, -21 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player.cc	View	1	6 chunks	+50 lines, -42 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/audio_player.js	View		9 chunks	+89 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/media_controls.js	View		4 chunks	+55 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/mediaplayer_scripts.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/video_player.js	View		1 chunk	+6 lines, -23 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/mediaplayer.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10917188/4001

8 years, 3 months ago (2012-09-12 07:26:02 UTC) #3

commit-bot: I haz the power

Presubmit check for 10917188-4001 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 3 months ago (2012-09-12 07:26:10 UTC) #4

Vladislav Kaznacheev

Dmitry, please LGTM the 2 files under chrome/browser/chromeos

8 years, 3 months ago (2012-09-12 10:33:39 UTC) #5

LGTM

Expand Messages | Collapse Messages