Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 10917181: Use WebCompositorSupport instead of static functions in compositor_impl_android.cc (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use WebCompositorSupport instead of static functions in compositor_impl_android.cc The static functions will go away real soon now in favor of an injectable WebCompositorSupport on WebKitPlatformSupport. This prepares for the change. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
@aelias - please review @ben - please OWNERS stamp Alex - is there any way ...
8 years, 3 months ago (2012-09-11 03:35:48 UTC) #1
aelias_OOO_until_Jul13
sievers@ wrote and tested this against Android content shell (entirely in upstream), you can run ...
8 years, 3 months ago (2012-09-11 03:40:59 UTC) #2
jamesr
It looks from the android try result that this compiles, which is a pretty solid ...
8 years, 3 months ago (2012-09-11 03:58:54 UTC) #3
aelias_OOO_until_Jul13
LGTM I tested this doesn't break Android content shell.
8 years, 3 months ago (2012-09-11 05:00:37 UTC) #4
jamesr
On 2012/09/11 05:00:37, aelias wrote: > LGTM > > I tested this doesn't break Android ...
8 years, 3 months ago (2012-09-11 05:04:21 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 3 months ago (2012-09-11 05:04:25 UTC) #6
no sievers
lgtm
8 years, 3 months ago (2012-09-11 17:01:25 UTC) #7
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-11 17:07:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10917181/1
8 years, 3 months ago (2012-09-11 17:07:28 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 19:22:46 UTC) #10
Change committed as 156095

Powered by Google App Engine
This is Rietveld 408576698