dart/lib/compiler/implementation/tree/nodes.dart - Issue 10917170: Improve handling of built-in identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/tree/nodes.dart

Issue 10917170: Improve handling of built-in identifiers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/compiler/implementation/tree/nodes.dart

diff --git a/dart/lib/compiler/implementation/tree/nodes.dart b/dart/lib/compiler/implementation/tree/nodes.dart

index 35c5ca4370e8305d479f02e526358142c4bf926e..9cc59532946740808c755eac82d62c4c52e2969c 100644

--- a/dart/lib/compiler/implementation/tree/nodes.dart

+++ b/dart/lib/compiler/implementation/tree/nodes.dart

@@ -706,8 +706,8 @@ class LiteralBool extends Literal<bool> {

LiteralBool asLiteralBool() => this;

bool get value {

- if (token.value == Keyword.TRUE) return true;

- if (token.value == Keyword.FALSE) return false;

+ if (token.stringValue === 'true') return true;

+ if (token.stringValue === 'false') return false;

(this.handler)(token, "not a bool ${token.value}");

}