Issue 10917169: Adjust defaults for touchscreen scrolling parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917169: Adjust defaults for touchscreen scrolling parameters. (Closed)

Created:
8 years, 3 months ago by rjkroege

Modified:
8 years, 3 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, arv (Not doing code reviews), jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adjust defaults for touchscreen scrolling parameters. After a scrolling review, slightly different default parameters were desired. Set them. BUG=145768 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155797

Patch Set 1 #

Total comments: 1

Patch Set 2 : review nit #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
M	chrome/browser/resources/gesture_config.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/gesture_event_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/gestures/gesture_configuration.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://chromiumcodereview.appspot.com/10917169/diff/1/ui/base/gestures/gesture_configuration.cc File ui/base/gestures/gesture_configuration.cc (right): https://chromiumcodereview.appspot.com/10917169/diff/1/ui/base/gestures/gesture_configuration.cc#newcode42 ui/base/gestures/gesture_configuration.cc:42: = 0.85; nit: wrap this like 30/31

8 years, 3 months ago (2012-09-10 16:27:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10917169/1004

8 years, 3 months ago (2012-09-10 17:13:18 UTC) #5

Change committed as 155797

Expand Messages | Collapse Messages