content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc - Issue 10917167: Refactor the P2PSocketDispatcher to be created on the RenderThread instead of the RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

Issue 10917167: Refactor the P2PSocketDispatcher to be created on the RenderThread instead of the RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change P2PSocketDispatcher to take the io message loop as input to fix existing unit tests Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/p2p/socket_dispatcher_host.cc ('K') | « content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc ('k') | content/browser/renderer_host/p2p/socket_host_udp.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

index d515dad49652d81e402014453966a700672d02cd..86e1d97f5616bf7a825e9c4bcb2a281ee5fc8208 100644

--- a/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

+++ b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

@@ -26,7 +26,7 @@ class P2PSocketHostTcpTest : public testing::Test {

MatchMessage(static_cast<uint32>(P2PMsg_OnSocketCreated::ID))))

.WillOnce(DoAll(DeleteArg<0>(), Return(true)));

- socket_host_.reset(new P2PSocketHostTcp(&sender_, 0, 0));

+ socket_host_.reset(new P2PSocketHostTcp(&sender_, 0));

socket_ = new FakeSocket(&sent_data_);

socket_->SetLocalAddress(ParseAddress(kTestLocalIpAddress, kTestPort1));

socket_host_->socket_.reset(socket_);