Issue 10917161: cras_output: Fix calculation of bytes per sample.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917161: cras_output: Fix calculation of bytes per sample. (Closed)

Created:
8 years, 3 months ago by dgreid

Modified:
8 years, 3 months ago

Reviewers:
zel

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

cras_output: Fix calculation of bytes per sample. bytes_per_frame_ is bytes_per_sample * num_channels. When calculating bytes_per_sample from bytes_per_frame, divide by the number of channels, the amount of frames we are rendering is not important here. BUG=chromium-os:34241 TEST=youtube videos make noise on ChromeOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155786

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/audio/linux/cras_output.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgreid@chromium.org/10917161/1

8 years, 3 months ago (2012-09-10 16:54:42 UTC) #2

Change committed as 155786

Expand Messages | Collapse Messages