Issue 10917142: Adding myself to OWNERS files for signin related directories.

Issue 10917142: Adding myself to OWNERS files for signin related directories. (Closed)

Created:
8 years, 3 months ago by Roger Tawa OOO till Jul 10th

Modified:
8 years, 3 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), haitaol1, akalin, tim (not reviewing), tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding myself to OWNERS files for signin related directories. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155523

Patch Set 2 : Removing rickcam@ #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/signin/OWNERS	View		1 chunk	+2 lines, -1 line	1 comment	Download
	M	chrome/browser/ui/sync/OWNERS	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

lgtm http://codereview.chromium.org/10917142/diff/1/chrome/browser/ui/sync/OWNERS File chrome/browser/ui/sync/OWNERS (left): http://codereview.chromium.org/10917142/diff/1/chrome/browser/ui/sync/OWNERS#oldcode5 chrome/browser/ui/sync/OWNERS:5: rickcam@chromium.org Please remove rickcam@ while you're at it.

8 years, 3 months ago (2012-09-07 21:07:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10917142/3001

8 years, 3 months ago (2012-09-07 21:15:06 UTC) #4

tfarina

https://chromiumcodereview.appspot.com/10917142/diff/3001/chrome/browser/signin/OWNERS File chrome/browser/signin/OWNERS (right): https://chromiumcodereview.appspot.com/10917142/diff/3001/chrome/browser/signin/OWNERS#newcode2 chrome/browser/signin/OWNERS:2: tim@chromium.org if it needs to be in alphabetical order, ...

8 years, 3 months ago (2012-09-09 00:45:36 UTC) #6

Roger Tawa OOO till Jul 10th

8 years, 3 months ago (2012-09-09 02:38:20 UTC) #7

doh!

Already committed, I'll make another patch.

Thanks,
Roger

-


On Sat, Sep 8, 2012 at 8:45 PM,  <tfarina@chromium.org> wrote:
>
>
https://chromiumcodereview.appspot.com/10917142/diff/3001/chrome/browser/sign...
> File chrome/browser/signin/OWNERS (right):
>
>
https://chromiumcodereview.appspot.com/10917142/diff/3001/chrome/browser/sign...
> chrome/browser/signin/OWNERS:2: tim@chromium.org
> if it needs to be in alphabetical order, so tim after roger :)
>
> https://chromiumcodereview.appspot.com/10917142/

Expand Messages | Collapse Messages