Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 10917127: webkit: Resolve blob elements early in ResourceRequestBody::ResolveElementsAndCreateUploadData() to… (Closed)

Created:
8 years, 3 months ago by hashimoto
Modified:
8 years, 3 months ago
Reviewers:
kinuko, tony
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

webkit: Resolve blob elements early in ResourceRequestBody::ResolveElementsAndCreateUploadData() to avoid code duplication BUG=141834 TEST=test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155463

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -30 lines) Patch
M webkit/glue/resource_request_body.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/resource_request_body.cc View 5 chunks +21 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
Please review
8 years, 3 months ago (2012-09-07 05:00:10 UTC) #1
kinuko
lgtm
8 years, 3 months ago (2012-09-07 05:06:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10917127/2001
8 years, 3 months ago (2012-09-07 05:49:38 UTC) #3
commit-bot: I haz the power
Presubmit check for 10917127-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-07 05:49:40 UTC) #4
hashimoto
tony, Could you review this change as an owner?
8 years, 3 months ago (2012-09-07 17:25:45 UTC) #5
tony
rs lgtm
8 years, 3 months ago (2012-09-07 17:40:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10917127/2001
8 years, 3 months ago (2012-09-07 17:46:01 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 20:09:17 UTC) #8
Change committed as 155463

Powered by Google App Engine
This is Rietveld 408576698