Issue 10917124: linux-aura: Fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917124: linux-aura: Fix build. (Closed)

Created:
8 years, 3 months ago by sadrul

Modified:
8 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux-aura: Fix build. The stub implementation is necessary for all non-chromeos platforms. BUG=none TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155297

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/stubs_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

8 years, 3 months ago (2012-09-07 02:45:38 UTC) #2

Lgtm
On Sep 6, 2012 7:41 PM, <sadrul@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> linux-aura: Fix build.
>
> The stub implementation is necessary for all non-chromeos platforms.
>
> BUG=none
> TBR=thakis@chromium.org
>
> Please review this at
http://codereview.chromium.**org/10917124/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/views/stubs_**aura.cc
>
>
> Index: chrome/browser/ui/views/stubs_**aura.cc
> diff --git a/chrome/browser/ui/views/**stubs_aura.cc
> b/chrome/browser/ui/views/**stubs_aura.cc
> index 29429b46f6de8277d653f304070b7d**6ca8e16cad..**
> 080950e47e7a16edc23d5080e07981**1d3a84a8b0 100644
> --- a/chrome/browser/ui/views/**stubs_aura.cc
> +++ b/chrome/browser/ui/views/**stubs_aura.cc
> @@ -68,7 +68,7 @@ void ShowImportProgressDialog(**uint16 items,
>
>  }  // namespace importer
>
> -#if defined(OS_WIN)
> +#if !defined(OS_CHROMEOS)
>  // static
>  void ExternalProtocolHandler::**RunExternalProtocolDialog(
>      const GURL& url, int render_process_host_id, int routing_id) {
>
>
>

Expand Messages | Collapse Messages