Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5006)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 10917120: Activate the VariationsService for ChromeOS and ensure that it does not ping the server until the E… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: nikita nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 315f7a07030fe51ecf6090bf493edde9c717657f..f84243a7d5bb553281db721a38075f06026d46c4 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1426,23 +1426,22 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
RecordPreReadExperimentTime("Startup.BrowserOpenTabs",
base::TimeTicks::Now() - browser_open_start);
- // TODO(mad): Move this call in a proper place on CrOS.
- // http://crosbug.com/17687
-#if !defined(OS_CHROMEOS)
// If we're running tests (ui_task is non-null), then we don't want to
// call FetchLanguageListFromTranslateServer or
// StartRepeatedVariationsSeedFetch.
if (parameters().ui_task == NULL) {
- // Request new variations seed information from server.
- browser_process_->variations_service()->
- StartRepeatedVariationsSeedFetch();
-
+#if !defined(OS_CHROMEOS)
+ // TODO(mad): Move this call in a proper place on CrOS.
+ // http://crosbug.com/17687
if (translate_manager_ != NULL) {
translate_manager_->FetchLanguageListFromTranslateServer(
profile_->GetPrefs());
}
- }
#endif
+ // Request new variations seed information from server.
MAD 2012/09/10 17:35:03 This is not within "if (parameters().ui_task == NU
SteveT 2012/09/10 19:33:52 It still is. Perhaps it'd be more clear if I moved
MAD 2012/09/10 19:46:17 D'Ho! :-) Yeah, maybe it would be better... Sorry
+ browser_process_->variations_service()->
+ StartRepeatedVariationsSeedFetch();
+ }
run_message_loop_ = true;
} else {

Powered by Google App Engine
This is Rietveld 408576698