Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5266)

Unified Diff: chrome/browser/metrics/variations/resource_request_allowed_notifier.cc

Issue 10917120: Activate the VariationsService for ChromeOS and ensure that it does not ping the server until the E… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: asvit nit 2 Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/resource_request_allowed_notifier.cc
diff --git a/chrome/browser/metrics/variations/resource_request_allowed_notifier.cc b/chrome/browser/metrics/variations/resource_request_allowed_notifier.cc
new file mode 100644
index 0000000000000000000000000000000000000000..59f655ca8f5ddd19d60cad0ed9b2993dff99484c
--- /dev/null
+++ b/chrome/browser/metrics/variations/resource_request_allowed_notifier.cc
@@ -0,0 +1,112 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/variations/resource_request_allowed_notifier.h"
+
+#include "base/metrics/histogram.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "content/public/browser/notification_service.h"
+
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/login/wizard_controller.h"
+#endif
+
+ResourceRequestAllowedNotifier::ResourceRequestAllowedNotifier() :
+#if defined(OS_CHROMEOS)
+ // Check this once immediately at creation time. It is not expected to
+ // change until the corresponding notification is received.
+ was_waiting_for_user_to_accept_eula_(
+ !chromeos::WizardController::IsEulaAccepted()),
+#endif
+ was_waiting_for_network_(false),
+ observer_(NULL) {
+ net::NetworkChangeNotifier::AddConnectionTypeObserver(this);
+}
+
+ResourceRequestAllowedNotifier::~ResourceRequestAllowedNotifier() {
+ net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
+}
+
+void ResourceRequestAllowedNotifier::SetObserver(Observer* observer) {
+ DCHECK(!observer_ && observer);
+ observer_ = observer;
+}
+
+void ResourceRequestAllowedNotifier::ClearObserver() {
+ DCHECK(observer_);
+ observer_ = NULL;
+}
+
+bool ResourceRequestAllowedNotifier::ResourceRequestsAllowed() {
+ was_waiting_for_network_ = net::NetworkChangeNotifier::IsOffline();
+
+ return
+#if defined(OS_CHROMEOS)
+ !was_waiting_for_user_to_accept_eula_ &&
+#endif
+ !was_waiting_for_network_;
+}
+
+void ResourceRequestAllowedNotifier::RegisterForEulaAcceptedNotification(
+ chromeos::WizardController* source) {
+#if defined(OS_CHROMEOS)
+ registrar_.Add(this, chrome::NOTIFICATION_WIZARD_EULA_ACCEPTED,
+ content::NotificationSource(
+ content::Source<chromeos::WizardController>(source)));
+#endif
+}
+
+void ResourceRequestAllowedNotifier::
+ SetWasWaitingForNetworkForTesting(bool waiting) {
+ was_waiting_for_network_ = waiting;
+}
+
+#if defined(OS_CHROMEOS)
+void ResourceRequestAllowedNotifier::
+ SetWasWaitingForEulaForTesting(bool waiting) {
+ was_waiting_for_user_to_accept_eula_ = waiting;
+}
+#endif
+
+void ResourceRequestAllowedNotifier::MaybeNotifyObservers() {
+ // Need to ensure that all criteria are met before notifying observers.
+ if (observer_ && ResourceRequestsAllowed()) {
+ DVLOG(1) << "Notifying observer of state change.";
+ observer_->OnResourceRequestsAllowed();
+ }
+}
+
+#if defined(OS_CHROMEOS)
+void ResourceRequestAllowedNotifier::Observe(
+ int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
+ DCHECK_EQ(chrome::NOTIFICATION_WIZARD_EULA_ACCEPTED, type);
+ registrar_.Remove(this, chrome::NOTIFICATION_WIZARD_EULA_ACCEPTED, source);
+
+ // If the observing service did not fail earlier due to an unaccepted EULA,
+ // do not notify it.
+ if (was_waiting_for_user_to_accept_eula_) {
+ DVLOG(1) << "EULA was accepted.";
+ was_waiting_for_user_to_accept_eula_ = false;
+ MaybeNotifyObservers();
+ }
+}
+#endif
+
+// net::NetworkChangeNotifier::ConnectionTypeObserver implementation.
+void ResourceRequestAllowedNotifier::OnConnectionTypeChanged(
+ net::NetworkChangeNotifier::ConnectionType type) {
+ // Only attempt to notify observers if this was previously waiting for the
+ // network to reconnect, and new network state is actually available. This
+ // prevents the notifier from notifying the observer if the notifier was never
+ // waiting on the network, or if the network changes from one online state
+ // to another (for example, Wifi to 3G, or Wifi to Wifi, if the network were
+ // flaky).
+ if (was_waiting_for_network_ &&
+ type != net::NetworkChangeNotifier::CONNECTION_NONE) {
+ DVLOG(1) << "Network came back online.";
+ MaybeNotifyObservers();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698