Activate the VariationsService for ChromeOS and ensure that it does not ping the server until the E…

chrome/browser/chromeos/login/wizard_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/types.h>
 
@@ skipping 28 matching lines @@
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/cros_settings_names.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/options/options_util.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(USE_LINUX_BREAKPAD)
 #include "chrome/app/breakpad_linux.h"
 #endif
 
 using content::BrowserThread;
 
@@ skipping 396 matching lines @@
 
 void WizardController::OnUpdateCompleted() {
   OnOOBECompleted();
 }
 
 void WizardController::OnEulaAccepted() {
   time_eula_accepted_ = base::Time::Now();
   MarkEulaAccepted();
   bool enabled =
       OptionsUtil::ResolveMetricsReportingEnabled(usage_statistics_reporting_);
+
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_WIZARD_EULA_ACCEPTED,
+      content::NotificationSource(content::Source<WizardController>(this)),

[Nikita (slow), 2012/09/25 16:23:46]

As you're essentially using AllSources in ResourceRequestAllowedNotifier, do you
need to pass source here?

[SteveT, 2012/09/25 18:49:11]

This was suggested by Ilya. I believe we want to be as specific as we can, when
we can. It'll make things a step easier to update if we ever clean up this
dependency issue. It's also more precise.

+      content::NotificationService::NoDetails());
+
   CrosSettings::Get()->SetBoolean(kStatsReportingPref, enabled);
   if (enabled) {
 #if defined(USE_LINUX_BREAKPAD)
     // The crash reporter initialization needs IO to complete.
     base::ThreadRestrictions::ScopedAllowIO allow_io;
     InitCrashReporter();
 #endif
   }
 
   if (skip_update_enroll_after_eula_) {
@@ skipping 356 matching lines @@
   return zero_delay_enabled_;
 }
 
 // static
 void WizardController::SetZeroDelays() {
   kShowDelayMs = 0;
   zero_delay_enabled_ = true;
 }
 
 }  // namespace chromeos