Activate the VariationsService for ChromeOS and ensure that it does not ping the server until the E…

chrome/browser/chromeos/login/wizard_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/types.h>
 
@@ skipping 424 matching lines @@
 
 void WizardController::OnUpdateCompleted() {
   OnOOBECompleted();
 }
 
 void WizardController::OnEulaAccepted() {
   time_eula_accepted_ = base::Time::Now();
   MarkEulaAccepted();
   bool enabled =
       OptionsUtil::ResolveMetricsReportingEnabled(usage_statistics_reporting_);
+
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_WIZARD_EULA_ACCEPTED,
+      content::NotificationService::AllSources(),

[Ilya Sherman, 2012/09/11 22:51:27]

nit: Please specify a source rather than using AllSources()

[SteveT, 2012/09/12 17:56:10]

I knew I would get in trouble for this :) - Unfortunately it is currently not
easy on the receiving end to specify the specific WizardController that will be
the Source of this Notification. The WizardController is created deep in the
bowels of BaseLoginDisplayHost, where it is not easy for our
ResourceRequestAllowedNotifier to access it.

All existing listeners of this notification also listen on AllSources.

What's the usual course of action for these situations? I can see if we can
plumb the WizardController around, but it doesn't look clean.

[Ilya Sherman, 2012/09/12 20:30:01]

It looks like this is a new notification that you're adding, so I'm not sure
what you mean about the existing listeners ;)
I think we should do the work to plumb this through, or else specify a different
source (user account/profile?) that maps one-to-one to the controller.  The
second option is probably cleaner, if there's a suitable alternate source.

The danger with using AllSources() here is that if ChromeOS ever supports
multiple users being simultaneously logged in (and each having their own EULA?),
this will start listening to notifications from *all* users, which seems wrong.

[SteveT, 2012/09/14 20:25:09]

Done.

+      content::NotificationService::NoDetails());
+
   CrosSettings::Get()->SetBoolean(kStatsReportingPref, enabled);
   if (enabled) {
 #if defined(USE_LINUX_BREAKPAD)
     // The crash reporter initialization needs IO to complete.
     base::ThreadRestrictions::ScopedAllowIO allow_io;
     InitCrashReporter();
 #endif
   }
 
   if (skip_update_enroll_after_eula_) {
@@ skipping 343 matching lines @@
   return zero_delay_enabled_;
 }
 
 // static
 void WizardController::SetZeroDelays() {
   kShowDelayMs = 0;
   zero_delay_enabled_ = true;
 }
 
 }  // namespace chromeos