Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: lib/compiler/implementation/universe.dart

Issue 10917110: Revert "Collect the types used in is-checks in the resolver phase." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/typechecker.dart ('k') | lib/compiler/implementation/util/link.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/universe.dart
diff --git a/lib/compiler/implementation/universe.dart b/lib/compiler/implementation/universe.dart
index f6eefe1047c79e134200ca9ee137ee874162b7f4..af79f574212eebe0905491d232372e16aa4ef077 100644
--- a/lib/compiler/implementation/universe.dart
+++ b/lib/compiler/implementation/universe.dart
@@ -12,9 +12,8 @@ class Universe {
final Map<SourceString, Set<Selector>> invokedSetters;
final Map<SourceString, Set<Selector>> fieldGetters;
final Map<SourceString, Set<Selector>> fieldSetters;
- final Set<DartType> isChecks;
- // TODO(karlklose): move this data to RuntimeTypeInformation.
- Set<Element> checkedClasses;
+ // TODO(ngeoffray): This should be a Set<DartType>.
+ final Set<Element> isChecks;
final RuntimeTypeInformation rti;
Universe() : generatedCode = new Map<Element, CodeBuffer>(),
@@ -26,16 +25,9 @@ class Universe {
invokedSetters = new Map<SourceString, Set<Selector>>(),
fieldGetters = new Map<SourceString, Set<Selector>>(),
fieldSetters = new Map<SourceString, Set<Selector>>(),
- isChecks = new Set<DartType>(),
+ isChecks = new Set<Element>(),
rti = new RuntimeTypeInformation();
- // TODO(karlklose): add the set of instantiatedtypes as second argument.
- void computeRequiredTypes(Set<DartType> isChecks) {
- assert(checkedClasses == null);
- checkedClasses = new Set<Element>();
- isChecks.forEach((DartType t) => checkedClasses.add(t.element));
- }
-
void addGeneratedCode(WorkItem work, CodeBuffer codeBuffer) {
generatedCode[work.element] = codeBuffer;
}
« no previous file with comments | « lib/compiler/implementation/typechecker.dart ('k') | lib/compiler/implementation/util/link.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698