Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc

Issue 10917102: Context menus should appear above the touch point if invoked by long press. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc
diff --git a/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc b/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc
index fc54bc19c719e68a1ed2694f380d4555818b1aaf..ec8b53cb743d0f68a34cb3bd675ea5360d335391 100644
--- a/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc
+++ b/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc
@@ -42,10 +42,15 @@ RenderViewContextMenuViews* RenderViewContextMenuViews::Create(
}
#endif // OS_WIN
-void RenderViewContextMenuViews::RunMenuAt(views::Widget* parent,
- const gfx::Point& point) {
+void RenderViewContextMenuViews::RunMenuAt(
+ views::Widget* parent,
+ const gfx::Point& point,
+ const content::ContextMenuSourceType& type) {
+ views::MenuItemView::AnchorPosition anchor_position =
+ type == content::CONTEXT_MENU_SOURCE_GESTURE ?
+ views::MenuItemView::BOTTOMCENTER : views::MenuItemView::TOPLEFT;
sky 2012/09/06 16:35:03 Why do we want BOTTOMCENTER for long press?
varunjain 2012/09/06 16:43:45 request from UX was to display the context menu ce
if (menu_runner_->RunMenuAt(parent, NULL, gfx::Rect(point, gfx::Size()),
- views::MenuItemView::TOPLEFT, views::MenuRunner::HAS_MNEMONICS |
+ anchor_position, views::MenuRunner::HAS_MNEMONICS |
views::MenuRunner::CONTEXT_MENU) ==
views::MenuRunner::MENU_DELETED)
return;

Powered by Google App Engine
This is Rietveld 408576698