content/browser/web_contents/web_contents_view_mac.mm - Issue 10917102: Context menus should appear above the touch point if invoked by long press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_mac.mm

Issue 10917102: Context menus should appear above the touch point if invoked by long press. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_view_mac.h ('k') | content/browser/web_contents/web_contents_view_win.h » ('j') | content/port/browser/render_view_host_delegate_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_mac.mm

diff --git a/content/browser/web_contents/web_contents_view_mac.mm b/content/browser/web_contents/web_contents_view_mac.mm

index 7c2a0e9bb8a620ae1a3301a2c07da94011e378d7..9240d9271dd014eb96114222f48e7cdb6070d40a 100644

--- a/content/browser/web_contents/web_contents_view_mac.mm

+++ b/content/browser/web_contents/web_contents_view_mac.mm

@@ -281,7 +281,8 @@ void WebContentsViewMac::TakeFocus(bool reverse) {

}

void WebContentsViewMac::ShowContextMenu(

- const content::ContextMenuParams& params) {

+ const content::ContextMenuParams& params,

+ const content::ContextMenuSourceType& type) {

// Allow delegates to handle the context menu operation first.

if (web_contents_->GetDelegate() &&

web_contents_->GetDelegate()->HandleContextMenu(params)) {

@@ -289,7 +290,7 @@ void WebContentsViewMac::ShowContextMenu(

}

if (delegate())

- delegate()->ShowContextMenu(params);

+ delegate()->ShowContextMenu(params, type);

else

DLOG(ERROR) << "Cannot show context menus without a delegate.";

}