chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc - Issue 10917102: Context menus should appear above the touch point if invoked by long press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc

Issue 10917102: Context menus should appear above the touch point if invoked by long press. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | content/port/browser/render_view_host_delegate_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc

diff --git a/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc b/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc

index fc54bc19c719e68a1ed2694f380d4555818b1aaf..548d0c277ddb4bc6d5f3c55c2dde92364bc71e39 100644

--- a/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc

+++ b/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc

@@ -42,10 +42,15 @@ RenderViewContextMenuViews* RenderViewContextMenuViews::Create(

}

#endif // OS_WIN

-void RenderViewContextMenuViews::RunMenuAt(views::Widget* parent,

- const gfx::Point& point) {

+void RenderViewContextMenuViews::RunMenuAt(

+ views::Widget* parent,

+ const gfx::Point& point,

+ const content::ContextMenuSourceType& type) {

+ views::MenuItemView::AnchorPosition anchor_position =

+ type == content::CONTEXT_MENU_SOURCE_TOUCH ?

+ views::MenuItemView::BOTTOMCENTER : views::MenuItemView::TOPLEFT;

if (menu_runner_->RunMenuAt(parent, NULL, gfx::Rect(point, gfx::Size()),

- views::MenuItemView::TOPLEFT, views::MenuRunner::HAS_MNEMONICS |

+ anchor_position, views::MenuRunner::HAS_MNEMONICS |

views::MenuRunner::CONTEXT_MENU) ==

views::MenuRunner::MENU_DELETED)

return;