Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10917090: Update drag edge indicator view per request by UX team (Closed)

Created:
8 years, 3 months ago by oshima
Modified:
8 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Update drag edge indicator view per request by UX team * no docking area at the lower corner of the screen * animation between white/black * changed thickness to 1px (dip) BUG=none TEST=test updated Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155065

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -90 lines) Patch
M ash/display/mouse_cursor_event_filter.cc View 1 2 3 2 chunks +9 lines, -20 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 3 chunks +41 lines, -41 lines 0 comments Download
M ash/display/shared_display_edge_indicator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 5 chunks +46 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
8 years, 3 months ago (2012-09-05 19:56:32 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/10917090/diff/4002/ash/display/mouse_cursor_event_filter.cc File ash/display/mouse_cursor_event_filter.cc (right): http://codereview.chromium.org/10917090/diff/4002/ash/display/mouse_cursor_event_filter.cc#newcode29 ash/display/mouse_cursor_event_filter.cc:29: // Minimum hight of an indicator on the ...
8 years, 3 months ago (2012-09-05 20:03:07 UTC) #2
oshima
http://codereview.chromium.org/10917090/diff/4002/ash/display/mouse_cursor_event_filter.cc File ash/display/mouse_cursor_event_filter.cc (right): http://codereview.chromium.org/10917090/diff/4002/ash/display/mouse_cursor_event_filter.cc#newcode29 ash/display/mouse_cursor_event_filter.cc:29: // Minimum hight of an indicator on the display ...
8 years, 3 months ago (2012-09-05 20:42:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10917090/4003
8 years, 3 months ago (2012-09-05 20:58:33 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 00:14:21 UTC) #5
Change committed as 155065

Powered by Google App Engine
This is Rietveld 408576698