Issue 10917086: Push stacktrace and die if the receiver is of unknown type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917086: Push stacktrace and die if the receiver is of unknown type. (Closed)

Created:
8 years, 3 months ago by Toon Verwaest

Modified:
8 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Push stacktrace and die if the receiver is of unknown type. Committed: https://code.google.com/p/v8/source/detail?r=12443

Patch Set 1 : u #

Total comments: 2

Patch Set 2 : Addressing comments. #

Patch Set 3 : Fixed bounds #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	src/isolate.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM if confirmed to push usable content onto the stack. And comments. https://chromiumcodereview.appspot.com/10917086/diff/5/src/isolate.cc File src/isolate.cc ...

8 years, 3 months ago (2012-09-05 12:03:48 UTC) #2

Addressed comments.

Expand Messages | Collapse Messages