Issue 10917080: Histogram - add check for external LinearHistogram data with mismatching range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917080: Histogram - add check for external LinearHistogram data with mismatching range. (Closed)

Created:
8 years, 3 months ago by hshi1

Modified:
8 years, 3 months ago

Reviewers:
zel

CC:
chromium-reviews, MAD, nkostylev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, Ilya Sherman, davemoore+watch_chromium.org, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Histogram - add check for external LinearHistogram data with mismatching range. This adds an extra step of validation for LinearHistogram data (also known as enum data) coming from an external data source: if a histogram already exists for the specified name but the range of the new data does not match the existing histogram, then discard the new data to prevent crashing chrome. BUG=143714 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154887

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/browser/chromeos/external_metrics.cc	View	1	3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/10917080/7001

8 years, 3 months ago (2012-09-05 00:27:10 UTC) #3

Change committed as 154887

Expand Messages | Collapse Messages