Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 10917075: events: Move some files into ui/base/events/ (Closed)

Created:
8 years, 3 months ago by sadrul
Modified:
8 years, 3 months ago
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, kkania, mazda+watch_chromium.org, browser-components-watch_chromium.org, dcheng, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, derat+watch_chromium.org, Randy Smith (Not in Mondays), penghuang+watch_chromium.org, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Aaron Boodman, robertshield, James Su, davemoore+watch_chromium.org, tfarina
Visibility:
Public.

Description

events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154817

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -1105 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_activation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/bezel_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/system_pinch_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/two_finger_drag_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overlay_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/partial_screenshot_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_modality_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager2.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_drop_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/event_disposition.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/event_utils.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/event_utils_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/event_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/gtk/event_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/event_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_collection_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/unhandled_keyboard_event_handler_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/automated_ui_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/native_web_keyboard_event.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/native_web_keyboard_event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 2 chunks +2 lines, -2 lines 0 comments Download
content/renderer/render_view_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/apps_grid_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_result_list_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/device_list_updater_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/aura/root_window.h View 1 chunk +1 line, -1 line 0 comments Download
ui/aura/root_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_linux.cc View 2 chunks +5 lines, -5 lines 0 comments Download
ui/aura/root_window_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/compound_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/compound_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/input_method_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/event_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/events_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/events_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
ui/base/event.h View 1 chunk +0 lines, -604 lines 0 comments Download
M ui/base/event.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/base/events.h View 1 chunk +0 lines, -231 lines 0 comments Download
A + ui/base/events/event.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ui/base/events/event_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/events/event_dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/base/events/event_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/events/event_target.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/gestures/gesture_point.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/gestures/gesture_recognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gestures/gesture_recognizer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gestures/gesture_recognizer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/gestures/gesture_sequence.h View 1 chunk +1 line, -1 line 0 comments Download
ui/base/gestures/gesture_sequence.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/gestures/gesture_types.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/character_composer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/character_composer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/base/ime/input_method_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_ibus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/mock_input_method.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/keycodes/keyboard_code_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/events_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/events_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/events_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/link.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/textfield_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/accelerator_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/input_method_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/ime/input_method_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/ime/mock_input_method.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mouse_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_desktop_window_move_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_window_event_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
The main change is: ui/base/event.h -> ui/base/events/event.h and ui/base/events.h -> ui/base/events/event_constants.h (should the latter be ...
8 years, 3 months ago (2012-09-04 18:04:02 UTC) #1
Ben Goodger (Google)
lgtm!
8 years, 3 months ago (2012-09-04 19:26:30 UTC) #2
sadrul
+jam@ for some of the content/ changes. TBR'ing for these changes since those are only ...
8 years, 3 months ago (2012-09-04 21:21:08 UTC) #3
tfarina
8 years, 3 months ago (2012-09-09 22:48:21 UTC) #4
On 2012/09/04 18:04:02, sadrul wrote:
> The main change is: ui/base/event.h -> ui/base/events/event.h and
> ui/base/events.h -> ui/base/events/event_constants.h (should the latter be
split
> into two: event_constants.h and event_utils.h?)

I agree with this. But looking into it, I see some enum types and the utility
functions. So I think event_utils.h makes more sense, I can rename that file if
you and Ben agree. I don't think separating the enum types in another file will
help much, because event_utils.h will have to include
event_constants.h/event_types.h.

Powered by Google App Engine
This is Rietveld 408576698