Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 10917026: Switch Extensions::TabHelper to use WebContents, WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase only Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/tabs/pinned_tab_codec.cc ('k') | chrome/browser/ui/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/tab_strip_model.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc
index 3885ee897e0a567aff5f844a96cb3f477d28ca09..c622f87da28b953a5db28644bbfea2f0403e8e31 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model.cc
@@ -120,8 +120,9 @@ void TabStripModel::InsertTabContentsAt(int index,
int add_types) {
bool active = add_types & ADD_ACTIVE;
// Force app tabs to be pinned.
- bool pin =
- contents->extension_tab_helper()->is_app() || add_types & ADD_PINNED;
+ extensions::TabHelper* extensions_tab_helper =
+ extensions::TabHelper::FromWebContents(contents->web_contents());
+ bool pin = extensions_tab_helper->is_app() || add_types & ADD_PINNED;
index = ConstrainInsertionIndex(index, pin);
// In tab dragging situations, if the last tab in the window was detached
@@ -565,8 +566,8 @@ bool TabStripModel::IsMiniTab(int index) const {
}
bool TabStripModel::IsAppTab(int index) const {
- TabContents* contents = GetTabContentsAt(index);
- return contents && contents->extension_tab_helper()->is_app();
+ WebContents* contents = GetTabContentsAt(index)->web_contents();
+ return contents && extensions::TabHelper::FromWebContents(contents)->is_app();
}
bool TabStripModel::IsTabBlocked(int index) const {
@@ -999,7 +1000,8 @@ void TabStripModel::Observe(int type,
// Iterate backwards as we may remove items while iterating.
for (int i = count() - 1; i >= 0; i--) {
TabContents* contents = GetTabContentsAt(i);
- if (contents->extension_tab_helper()->extension_app() == extension) {
+ if (extensions::TabHelper::FromWebContents(contents->web_contents())->
+ extension_app() == extension) {
// The extension an app tab was created from has been nuked. Delete
// the WebContents. Deleting a WebContents results in a notification
// of type NOTIFICATION_WEB_CONTENTS_DESTROYED; we do the necessary
« no previous file with comments | « chrome/browser/ui/tabs/pinned_tab_codec.cc ('k') | chrome/browser/ui/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698