Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 10917026: Switch Extensions::TabHelper to use WebContents, WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase only Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index e8d368987b86f835bccac0e7739dcf36514c5f3b..bd2e0eb7b45a93351599f729f37c2c092967f092 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -642,7 +642,7 @@ void MenuManager::ExecuteCommand(Profile* profile,
// Add the tab info to the argument list.
// No tab info in a platform app.
if (!extension || !extension->is_platform_app()) {
- // Note: web_contents only NULL in unit tests :(
+ // Note: web_contents are NULL in unit tests :(
if (web_contents)
args->Append(ExtensionTabUtil::CreateTabValue(web_contents, extension));
else
@@ -666,11 +666,10 @@ void MenuManager::ExecuteCommand(Profile* profile,
WriteToStorage(extension);
}
- TabContents* tab_contents = web_contents ?
- TabContents::FromWebContents(web_contents) : NULL;
- if (tab_contents && extension) {
- tab_contents->extension_tab_helper()->active_tab_permission_manager()->
- GrantIfRequested(extension);
+ // Note: web_contents are NULL in unit tests :(
+ if (web_contents && extensions::TabHelper::FromWebContents(web_contents)) {
+ extensions::TabHelper::FromWebContents(web_contents)->
+ active_tab_permission_manager()->GrantIfRequested(extension);
}
event_router->DispatchEventToExtension(
« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/extensions/page_action_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698