Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 10916349: linux_aura: Start implementing DesktopRootWindowHostLinux (Closed)

Created:
8 years, 3 months ago by Elliot Glaysher
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Start implementing DesktopRootWindowHostLinux This starts copying code from RootWindowHostLinux and the various x11 helper classes into the new central class on Ben's new architecture. Things that work: - Opening the inital views_examples window - Clicking on things Things that dont work: - Opening other windows - Closing windows BUG=146077 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -25 lines) Patch
M ui/views/widget/desktop_native_widget_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_native_widget_helper_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_root_window_host_linux.h View 2 chunks +99 lines, -1 line 0 comments Download
M ui/views/widget/desktop_root_window_host_linux.cc View 6 chunks +530 lines, -14 lines 0 comments Download
M ui/views/widget/x11_window_event_filter.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/widget/x11_window_event_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
In the interest of keeping patches reasonable, here's the initial take on DRWHL. Most of ...
8 years, 3 months ago (2012-09-17 21:29:37 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-17 21:31:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10916349/1
8 years, 3 months ago (2012-09-17 21:32:35 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-17 22:07:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10916349/1
8 years, 3 months ago (2012-09-17 22:28:11 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 22:31:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10916349/1
8 years, 3 months ago (2012-09-18 16:28:52 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 17:40:46 UTC) #8
Change committed as 157377

Powered by Google App Engine
This is Rietveld 408576698