Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10916348: Switch SSLTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Switch SSLTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157292

Patch Set 1 #

Patch Set 2 : fix views #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -437 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler.cc View 3 chunks +7 lines, -8 lines 0 comments Download
A + chrome/browser/ssl/ssl_client_certificate_selector.h View 2 chunks +7 lines, -5 lines 0 comments Download
A + chrome/browser/ssl/ssl_tab_helper.h View 3 chunks +12 lines, -9 lines 0 comments Download
A + chrome/browser/ssl/ssl_tab_helper.cc View 7 chunks +35 lines, -35 lines 0 comments Download
D chrome/browser/ssl_client_certificate_selector.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/tab_contents/tab_contents_ssl_helper.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 1 chunk +0 lines, -252 lines 0 comments Download
M chrome/browser/ui/android/ssl_client_certificate_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Avi (use Gerrit)
abarth: ssl ben: ui
8 years, 3 months ago (2012-09-17 21:03:25 UTC) #1
abarth-chromium
SSL LGTM
8 years, 3 months ago (2012-09-17 21:08:37 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-17 21:24:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10916348/1
8 years, 3 months ago (2012-09-17 21:26:23 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 22:13:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10916348/1
8 years, 3 months ago (2012-09-17 22:21:29 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 22:25:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10916348/1
8 years, 3 months ago (2012-09-17 23:27:36 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 23:34:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10916348/11002
8 years, 3 months ago (2012-09-17 23:41:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10916348/7004
8 years, 3 months ago (2012-09-18 01:11:45 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 03:58:58 UTC) #12 
Change committed as 157292

Powered by Google App Engine
This is Rietveld 408576698