Ignore --use-spdy=off command line option if spdy.disabled pref is

Ignore --use-spdy=off command line option if spdy.disabled pref is
managed by the policy.

Implement the following priority order for spdy.disabled pref and
--use-spdy command line options.

1. If there is a policy for spdy.disabled, use its value
2. If there is a command line for --use-spdy, use its value
3. If there is a user pref for spdy.disabled, use its value
4. Otherwise use the default value of the pref for spdy.pref (which will
   always enable SPDY).

Part of priortity order was fixed earlier in
https://chromiumcodereview.appspot.com/10911198 

R=joaodasilva@chromium.org
BUG=83895
TEST=browser unit tests. Specify --disable-spdy command line switch
and in chrome://net-internals SPDY should say it is off.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157471

[ramant (doing other things), 2012-09-17 17:33:33]

Hi Joao,
 Finished implementing the 2nd part of the fix you had suggested for controlling
spdy.enabled preference. Would appreciate your comments.

thanks
raman

[Joao da Silva, 2012-09-18 11:35:56]

lgtm, thanks for doing this!

http://codereview.chromium.org/10916341/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10916341/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main.cc:120: #include "policy/policy_constants.h"
policy_service.h is always available, but this header only exists if
ENABLE_CONFIGURATION_POLICY is defined. Please #include it below within #ifdefs
(the linux_redux and android try bots should catch this).

http://codereview.chromium.org/10916341/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main.cc:218: // If "spdy.disabled" peference is
controlled via policy, then skip use-spdy
Nit: "peference" typo

[ramant (doing other things), 2012-09-18 21:16:22]

Many many thanks Joao da Silva,
raman

http://codereview.chromium.org/10916341/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10916341/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main.cc:120: #include "policy/policy_constants.h"
On 2012/09/18 11:35:56, Joao da Silva wrote:
> policy_service.h is always available, but this header only exists if
> ENABLE_CONFIGURATION_POLICY is defined. Please #include it below within
#ifdefs
> (the linux_redux and android try bots should catch this).

Done.

http://codereview.chromium.org/10916341/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main.cc:218: // If "spdy.disabled" peference is
controlled via policy, then skip use-spdy
On 2012/09/18 11:35:56, Joao da Silva wrote:
> Nit: "peference" typo

Done.

[commit-bot: I haz the power, 2012-09-18 21:16:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10916341/10001

[commit-bot: I haz the power, 2012-09-18 21:16:34]

Presubmit check for 10916341-10001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[ramant (doing other things), 2012-09-18 21:18:54]

Hi thestig@,
  Can I get OWNERs approval (or rubber stamp) please?

thanks much
raman

[Lei Zhang, 2012-09-18 22:02:03]

lgtm

[commit-bot: I haz the power, 2012-09-18 22:03:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10916341/10001

[commit-bot: I haz the power, 2012-09-19 01:50:57]

Change committed as 157471