Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 10916329: [Android] Request correctly sized favicon for recently closed tabs. (Closed)

Created:
8 years, 3 months ago by newt (away)
Modified:
8 years, 3 months ago
Reviewers:
Ted C, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Android] Request correctly sized favicon for recently closed tabs. The recently closed tabs are shown on the NTP next to a 16x16 favicon. Previously, we requested a 64x64 favicon and then resized it down. Now we request a 16x16 favicon from the start. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157593

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : Request 64px for list-entry-item #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/ntp_android/ntp_android.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
newt (away)
PTAL, thanks.
8 years, 3 months ago (2012-09-17 23:26:49 UTC) #1
Evan Stade
lgtm
8 years, 3 months ago (2012-09-18 08:45:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10916329/1
8 years, 3 months ago (2012-09-19 17:59:57 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/ntp_android/ntp_android.js: While running patch -p1 --forward --force; patching file chrome/browser/resources/ntp_android/ntp_android.js ...
8 years, 3 months ago (2012-09-19 17:59:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10916329/6001
8 years, 3 months ago (2012-09-19 18:08:37 UTC) #5
Ted C
lgtm...w/ the switch back to 64 for makeListEntryItem https://codereview.chromium.org/10916329/diff/6001/chrome/browser/resources/ntp_android/ntp_android.js File chrome/browser/resources/ntp_android/ntp_android.js (right): https://codereview.chromium.org/10916329/diff/6001/chrome/browser/resources/ntp_android/ntp_android.js#newcode811 chrome/browser/resources/ntp_android/ntp_android.js:811: var ...
8 years, 3 months ago (2012-09-19 18:24:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10916329/13001
8 years, 3 months ago (2012-09-19 18:26:12 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 20:12:37 UTC) #8
Change committed as 157593

Powered by Google App Engine
This is Rietveld 408576698