Convert themes.py to browser test

- testSetTheme was already covered (after adding theme name verification).
- testThemeUndo was already covered
- testThemeOverInstall was already covered
- testThemeInFullScreen -> TestInstallThemeInFullScreen
- testThemeReset -> TestThemeReset
- Runner was not running by default and is missing data files so it doesn't
  look like it has run in a while.

Remove automation hooks: GetThemeInfo, ResetToDefaultTheme

BUG=143637
TEST=browser_tests --gtest_filter=ExtensionInstallUIBrowserTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157427

[jam, 2012-09-17 22:23:59]

thanks. 

also if you notice any other now-uneeded automation calls

https://codereview.chromium.org/10916328/diff/10001/chrome/test/functional/th...
File chrome/test/functional/themes.py (left):

https://codereview.chromium.org/10916328/diff/10001/chrome/test/functional/th...
chrome/test/functional/themes.py:24: self.pprint(self.GetThemeInfo())
looks like GetThemeInfo be removed from pyauto.py and TestingAutomationProvider
now (along with WaitUntilDownloadedThemeSet)?

https://codereview.chromium.org/10916328/diff/10001/chrome/test/functional/th...
chrome/test/functional/themes.py:67: self.ResetToDefaultTheme()
ditto

[Nirnimesh, 2012-09-17 22:44:20]

Remove automation hooks GetThemeInfo & ResetToDefaultTheme. SetTheme is still
used elsewhere (but it does not require additional hooks).

PTAL

[jam, 2012-09-17 23:10:56]

lgtm

[Nirnimesh, 2012-09-17 23:45:22]

+aa for chrome/browser/extensions owner

[jam, 2012-09-18 15:41:17]

(btw I'm an owner for src/chrome so you don't need more owners to look at this)

https://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/...
File chrome/browser/extensions/extension_install_ui_browsertest.cc (right):

https://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/...
chrome/browser/extensions/extension_install_ui_browsertest.cc:115:
ui_test_utils::CloseAllInfoBars(chrome::GetActiveTabContents(browser()));
just noticed this. this shouldn't be necessary since each browser test starts
with a fresh browser.

[Nirnimesh, 2012-09-18 18:09:13]

-aa

http://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_ui_browsertest.cc (right):

http://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_ui_browsertest.cc:115:
ui_test_utils::CloseAllInfoBars(chrome::GetActiveTabContents(browser()));
On 2012/09/18 15:41:17, John Abd-El-Malek wrote:
> just noticed this. this shouldn't be necessary since each browser test starts
> with a fresh browser.

This was already there in other tests in this file. I thought it's because one
of the infobars might show up even on a clean profile (perhaps the "make chrome
the default browser" one?)

[jam, 2012-09-18 18:19:46]

https://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/...
File chrome/browser/extensions/extension_install_ui_browsertest.cc (right):

https://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/...
chrome/browser/extensions/extension_install_ui_browsertest.cc:115:
ui_test_utils::CloseAllInfoBars(chrome::GetActiveTabContents(browser()));
On 2012/09/18 18:09:14, Nirnimesh wrote:
> On 2012/09/18 15:41:17, John Abd-El-Malek wrote:
> > just noticed this. this shouldn't be necessary since each browser test
starts
> > with a fresh browser.
> 
> This was already there in other tests in this file.

ah, those are unnecessary too. can you take them all out?

> I thought it's because one
> of the infobars might show up even on a clean profile (perhaps the "make
chrome
> the default browser" one?)

test_launcher_utils::PrepareBrowserCommandLineForTests() disables all this stuff
by adding kNoFirstRun/kNoDefaultBrowserCheck etc (otherwise we'd have to add
code like the above to many tests)

[Nirnimesh, 2012-09-18 18:34:08]

Tests run fine locally. Going to CQ.

http://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_ui_browsertest.cc (right):

http://codereview.chromium.org/10916328/diff/7003/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_ui_browsertest.cc:115:
ui_test_utils::CloseAllInfoBars(chrome::GetActiveTabContents(browser()));
Removed all.

[jam, 2012-09-18 19:38:21]

lgtm

[commit-bot: I haz the power, 2012-09-18 19:43:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nirnimesh@chromium.org/10916328/22001

[commit-bot: I haz the power, 2012-09-18 22:08:53]

Change committed as 157427