Issue 10916326: Tighten up android_webview DEPS rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916326: Tighten up android_webview DEPS rules (Closed)

Created:
8 years, 3 months ago by joth

Modified:
8 years, 3 months ago

Reviewers:
Torne, Ben Murdoch

CC:
chromium-reviews, android-webview-reviews_google.com

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Tighten up android_webview DEPS rules Codifies the agreed layering :- native->browser->common renderer->common lib is at top, it may depend on anything but nothing depend in it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156980

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
A	android_webview/browser/DEPS	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	android_webview/common/DEPS	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	android_webview/renderer/DEPS	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/10916326/1

8 years, 3 months ago (2012-09-14 23:08:39 UTC) #3

Change committed as 156980

Expand Messages | Collapse Messages