Issue 10916322: app_list: Make contact results use the RTC extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916322: app_list: Make contact results use the RTC extension API. (Closed)

Created:
8 years, 3 months ago by Daniel Erat

Modified:
8 years, 3 months ago

Reviewers:
xiyuan, zel, Aaron Boodman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

app_list: Make contact results use the RTC extension API. This makes clicks on contacts' action icons trigger calls via the RTC extension API. BUG=141877 TEST=none TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157050

Patch Set 1 #

Patch Set 2 : diff against correct branch #

Patch Set 3 : merge #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -18 lines)			Patch
M	chrome/browser/extensions/api/rtc_private/rtc_private_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/rtc_private/rtc_private_api.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/app_list/search_builder.cc	View	6 chunks	+57 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10916322/6001

8 years, 3 months ago (2012-09-16 08:03:08 UTC) #6

Change committed as 157050

Expand Messages | Collapse Messages