Cleanup: quota::HostUsageCallback and quota::HostQuotaCallback do not need to pass host and type as…

Cleanup: quota::HostUsageCallback do not need to pass host and type as arguments

BUG=148900
TBR=mkwst@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157523

[calvinlo, 2012-09-14 12:29:14]

Finished part 1, cleaned up quota::HostUsageCallBack

[calvinlo, 2012-09-17 07:05:10]

I think I've fixed the try jobs now so probably a good time to do a first pass
review to see if I did this right.

[kinuko, 2012-09-17 19:15:42]

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_manager.cc
File webkit/quota/quota_manager.cc (right):

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_manager.cc#...
webkit/quota/quota_manager.cc:361: weak_factory_.GetWeakPtr(), host, type);
looks like we can call host() and type() here rather than passing them as args
to NewWaitableHostUsageCallback

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h
File webkit/quota/quota_types.h (left):

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h#old...
webkit/quota/quota_types.h:231: typedef CallbackQueueMap3<HostUsageCallback,
std::string,
I guess we can probably remove CallbackQueueMap3 now..?

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h
File webkit/quota/quota_types.h (right):

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h#new...
webkit/quota/quota_types.h:51: typedef base::Callback<void(int64 host_usage)>
HostUsageCallback;
Now this callback type doesn't necessarily be called 'HostUsage' callback. 
Probably we can simply call it UsageCallback (and also can rename host_usage ->
usage)

[calvinlo, 2012-09-18 05:59:18]

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_manager.cc
File webkit/quota/quota_manager.cc (right):

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_manager.cc#...
webkit/quota/quota_manager.cc:361: weak_factory_.GetWeakPtr(), host, type);
On 2012/09/17 19:15:42, kinuko wrote:
> looks like we can call host() and type() here rather than passing them as args
> to NewWaitableHostUsageCallback

Done.

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h
File webkit/quota/quota_types.h (left):

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h#old...
webkit/quota/quota_types.h:231: typedef CallbackQueueMap3<HostUsageCallback,
std::string,
On 2012/09/17 19:15:42, kinuko wrote:
> I guess we can probably remove CallbackQueueMap3 now..?

Done.

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h
File webkit/quota/quota_types.h (right):

http://codereview.chromium.org/10916313/diff/1/webkit/quota/quota_types.h#new...
webkit/quota/quota_types.h:51: typedef base::Callback<void(int64 host_usage)>
HostUsageCallback;
On 2012/09/17 19:15:42, kinuko wrote:
> Now this callback type doesn't necessarily be called 'HostUsage' callback. 
> Probably we can simply call it UsageCallback (and also can rename host_usage
->
> usage)

Done.

[kinuko, 2012-09-18 07:12:40]

lgtm

[commit-bot: I haz the power, 2012-09-18 08:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/10916313/16003

[commit-bot: I haz the power, 2012-09-18 08:06:16]

Presubmit check for 10916313-16003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui
    chrome/browser/browsing_data

Presubmit checks took 1.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[calvinlo, 2012-09-18 08:10:56]

On 2012/09/18 07:12:40, kinuko wrote:
> lgtm

Hi estade, can you please review the one line change in
chrome/browser/ui/webui/quota_internals_proxy.cc

Hi mkwst, can you please review the one line change in 
chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc

[calvinlo, 2012-09-18 08:15:42]

Hi estade, can you please review the one line change in
chrome/browser/ui/webui/quota_internals_proxy.cc

Hi mkwst, can you please review the one line change in 
chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc

[Evan Stade, 2012-09-18 08:48:43]

webui lgtm

[commit-bot: I haz the power, 2012-09-19 06:22:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/10916313/16003

[Mike West, 2012-09-19 06:35:50]

Sorry, I ended up being out more of yesterday than I expected.

browsing_data LGTM.

[commit-bot: I haz the power, 2012-09-19 09:23:43]

Change committed as 157523