Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 10916312: Support DIR_STANDALONE_EXTERNAL_EXTENSIONS on Chrome OS (Closed)

Created:
8 years, 3 months ago by Dmitry Polukhin
Modified:
8 years, 3 months ago
Reviewers:
Finnur, Nico
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Support DIR_STANDALONE_EXTERNAL_EXTENSIONS on Chrome OS This source of external extensions will be used on Chrome OS for installing board specific default extensions. They need to be from CWS same as other default apps on Chrome OS. BUG=149158 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/extensions/external_provider_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dmitry Polukhin
8 years, 3 months ago (2012-09-14 08:11:58 UTC) #1
Finnur
LGTM
8 years, 3 months ago (2012-09-14 10:02:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10916312/1
8 years, 3 months ago (2012-09-14 12:46:01 UTC) #3
commit-bot: I haz the power
Presubmit check for 10916312-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-14 12:46:04 UTC) #4
Dmitry Polukhin
+ Nico for OWNER review in chrome/
8 years, 3 months ago (2012-09-14 12:46:54 UTC) #5
Nico
lgtm stamp
8 years, 3 months ago (2012-09-14 12:54:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10916312/1
8 years, 3 months ago (2012-09-14 13:58:46 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 16:11:06 UTC) #8
Change committed as 156810

Powered by Google App Engine
This is Rietveld 408576698