Issue 10916308: Provide details about why we're dispatching runtime.onInstalled.

Issue 10916308: Provide details about why we're dispatching runtime.onInstalled. (Closed)

Created:
8 years, 3 months ago by Matt Perry

Modified:
8 years, 3 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Provide details about why we're dispatching runtime.onInstalled. Also, unregister for the event after dispatching, so we don't end up littering Preferences. BUG=134319, 145842 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157219

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : unreg it #

Total comments: 2

Patch Set 4 : update #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -8 lines)			Patch
M	chrome/browser/extensions/api/runtime/runtime_api.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/runtime/runtime_api.cc	View	1 2 3	4 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/event_router.cc	View		3 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/api/runtime.json	View	1 2 3	1 chunk	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

Coming: a patch for http://code.google.com/p/chromium/issues/detail?id=148898

8 years, 3 months ago (2012-09-14 22:48:31 UTC) #2

Aaron Boodman

LGTM w/ nit For the chrome-update thing, can we just have a different event? I ...

8 years, 3 months ago (2012-09-16 00:33:24 UTC) #3

Matt Perry

On 2012/09/16 00:33:24, Aaron Boodman wrote: > LGTM w/ nit > > For the chrome-update ...

8 years, 3 months ago (2012-09-17 19:35:19 UTC) #4

Matt Perry

http://codereview.chromium.org/10916308/diff/1005/chrome/common/extensions/api/runtime.json File chrome/common/extensions/api/runtime.json (right): http://codereview.chromium.org/10916308/diff/1005/chrome/common/extensions/api/runtime.json#newcode101 chrome/common/extensions/api/runtime.json:101: "enum": ["install", "upgrade"], On 2012/09/16 00:33:24, Aaron Boodman wrote: ...

8 years, 3 months ago (2012-09-17 19:39:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10916308/5008

8 years, 3 months ago (2012-09-17 19:39:23 UTC) #6

Change committed as 157219

Expand Messages | Collapse Messages