Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10916291: Only inject the HTML titlebar into toplevel frames. (Closed)

Created:
8 years, 3 months ago by jeremya
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, benwells
Visibility:
Public.

Description

Only inject the HTML titlebar into toplevel frames. R=mihaip@chromium.org BUG=147396 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/renderer/extensions/app_window_custom_bindings.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jeremya
8 years, 3 months ago (2012-09-13 18:33:09 UTC) #1
Mihai Parparita -not on Chrome
LGTM
8 years, 3 months ago (2012-09-13 20:10:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10916291/1
8 years, 3 months ago (2012-09-13 20:14:54 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 22:19:00 UTC) #4
Change committed as 156653

Powered by Google App Engine
This is Rietveld 408576698