Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 10916284: Disable type_profiler in pyautolib. (Closed)

Created:
8 years, 3 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
8 years, 2 months ago
Reviewers:
Nico, Nirnimesh
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Disable type_profiler in pyautolib. BUG=123758 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158853

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi Nirnimesh, Could you take a look at this change? It disables a "type_profiler" option ...
8 years, 2 months ago (2012-09-26 06:39:22 UTC) #1
Nirnimesh
lgtm
8 years, 2 months ago (2012-09-26 10:19:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10916284/7001
8 years, 2 months ago (2012-09-26 10:24:22 UTC) #3
commit-bot: I haz the power
Presubmit check for 10916284-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-26 10:24:25 UTC) #4
Dai Mikurube (NOT FULLTIME)
On 2012/09/26 10:19:01, Nirnimesh wrote: > lgtm Thanks. Checked the "Commit" box.
8 years, 2 months ago (2012-09-26 10:24:31 UTC) #5
Dai Mikurube (NOT FULLTIME)
Ah, forgot OWNERS... Nico, could you take a look? http://codereview.chromium.org/10916284/#msg1 describes this change.
8 years, 2 months ago (2012-09-26 10:26:24 UTC) #6
Nico
lgtm
8 years, 2 months ago (2012-09-26 15:40:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10916284/7001
8 years, 2 months ago (2012-09-26 15:40:50 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 19:14:23 UTC) #9
Change committed as 158853

Powered by Google App Engine
This is Rietveld 408576698